Skip to content

Conversation

@boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Oct 3, 2025

Release Summary:

Resolved issues:

related to #2812

Description of changes:

The restart test in dcQUIC is extremely flaky. At the same time, it is extremely difficult to reproduce it locally. I tried to run it on my Macbook, and run it on my forked repo, but the flakiness never show up. We suspect that Github Action is giving different kinds of MacBook with different architectures which makes the test flaky. For now, to reduce developer pain, I will disable the restart test on MacOS.

Call-outs:

  • We primarily notice that the restart test failed with UDP rather TCP. We suspect it is because how different protocols transfer data which leads to success or failure. For this PR, we want to test that theory and only disable the UDP test mentioned by refactor(s2n-quic-dc): disable restart test on MacOS #2839 (comment).
  • We shouldn't close the ticket since we can still investigate it later and find out what architecture of MacOS is triggering the flakiness. However, I can downgrade the priority of the ticket to medium/low.

Testing:

CI test: restart test shouldn't run on MacOS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang force-pushed the restart-inv branch 2 times, most recently from 66a4ae4 to e93b7c8 Compare October 30, 2025 18:49
@boquan-fang boquan-fang changed the title fix(s2n-quic-dc): resolve restart test flakiness on MacOS GithubAction Image refactor(s2n-quic-dc): disable restart test on MacOS Oct 30, 2025
@boquan-fang boquan-fang marked this pull request as ready for review October 30, 2025 22:45
@boquan-fang boquan-fang requested a review from a team as a code owner October 30, 2025 22:45
@boquan-fang boquan-fang enabled auto-merge (squash) October 31, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants